Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 28, 2024

Alternative to #1120

go get k8s.io/client-go@latest
go get k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go get github.com/operator-framework/[email protected]
go get github.com/operator-framework/[email protected]
bingo get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest

Fixup defers of SetFeatureGateDuringTest

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner August 28, 2024 15:52
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit fe2c506
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66cf66210a0fd80008f4500b
😎 Deploy Preview https://deploy-preview-1181--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tmshort tmshort changed the title Update client components ⚠️ Update client components Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (1b65ec9) to head (fe2c506).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1181   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files          35       35           
  Lines        1916     1916           
=======================================
  Hits         1485     1485           
  Misses        297      297           
  Partials      134      134           
Flag Coverage Δ
e2e 58.76% <ø> (ø)
unit 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go get k8s.io/client-go@latest
go get k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go get github.com/operator-framework/[email protected]
go get github.com/operator-framework/[email protected]
bingo get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest

Fixup defers of `SetFeatureGateDuringTest`

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort added this pull request to the merge queue Aug 28, 2024
Merged via the queue into operator-framework:main with commit ec9289e Aug 28, 2024
19 checks passed
@tmshort tmshort deleted the update-client branch August 28, 2024 20:33
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants